[FFmpeg-devel] [PATCH v2 02/11] avcodec/dovi_rpu: properly replace context header

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Apr 9 18:36:30 EEST 2024


Niklas Haas:
> From: Niklas Haas <git at haasn.dev>
> 
> This was never set in ff_dovi_ctx_replace(), leading to possibly
> out-of-date when copying from a sub-thread to the main thread.
> ---

Sub-thread to the main thread? update_thread_context is not called with
the main (user-facing) AVCodecContext.

>  libavcodec/dovi_rpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c
> index d95c7e03af9..bfb7b9fe661 100644
> --- a/libavcodec/dovi_rpu.c
> +++ b/libavcodec/dovi_rpu.c
> @@ -75,6 +75,7 @@ void ff_dovi_ctx_replace(DOVIContext *s, const DOVIContext *s0)
>  {
>      s->logctx = s0->logctx;
>      s->cfg = s0->cfg;
> +    s->header = s0->header;
>      s->mapping = s0->mapping;
>      s->color = s0->color;
>      for (int i = 0; i <= DOVI_MAX_DM_ID; i++)



More information about the ffmpeg-devel mailing list