[FFmpeg-devel] [PATCH] movenc: Allow writing timed ID3 metadata

[Martin Storsjö]

On Tue, 9 Apr 2024, James Almer wrote:

> On 4/4/2024 7:29 AM, Martin Storsjö wrote:
>> This is based on a spec at https://aomediacodec.github.io/id3-emsg/,
>> further based on ISO/IEC 23009-1:2019.
>> 
>> Within libavformat, timed ID3 metadata (already supported by the
>> mpegts demuxer and muxer) is handled as a separate data AVStream
>> with codec type AV_CODEC_ID_TIMED_ID3. However, it doesn't
>> have a corresponding track in the mov file - instead, these events
>> are written as separate toplevel 'emsg' boxes.
>> ---
>>   libavformat/movenc.c       | 49 ++++++++++++++++++++++++++++++++-
>>   libavformat/tests/movenc.c | 55 +++++++++++++++++++++++++++++++++-----
>>   tests/ref/fate/movenc      |  8 ++++++
>>   3 files changed, 104 insertions(+), 8 deletions(-)
>
> Should be ok.

Thanks for the review, pushed now.

// Martin