[FFmpeg-devel] [PATCH v2] opusdsp: add ability to modify deemphasis constant

[Lynne]

Apr 25, 2024, 02:08 by michael at niedermayer.cc:

> On Wed, Apr 24, 2024 at 12:58:54PM +0200, Lynne wrote:
>
>> Apr 24, 2024, 10:54 by dev at lynne.ee:
>>
>> > xHE-AAC relies on the same postfilter mechanism
>> > that Opus uses to improve clarity (albeit with a steeper
>> > deemphasis filter).
>> >
>> > The code to apply it is identical, it's still just a
>> > simple IIR low-pass filter. This commit makes it possible
>> > to use alternative constants.
>> >
>> > Version 2 changes:
>> > Move the deemphasis constant table to opustab.c and
>> > document its values better.
>> >
>>
>> v3 attached, forgot to port the native opus encoder.
>>
>
> make V=2 fate-checkasm-opusdsp
> TEST    checkasm-opusdsp
> ./tests/fate-run.sh fate-checkasm-opusdsp "/home/michael/fatesamples/fate/fate-suite/" "" "/home/michael/ffmpeg-git/ffmpeg" 'run tests/checkasm/checkasm --test=opusdsp' 'null' '' '' '1' '' '' '' '' '' '' '' '' '' ''
>  /home/michael/ffmpeg-git/ffmpeg/tests/checkasm/checkasm --test=opusdsp
> Test checkasm-opusdsp failed. Look at tests/data/fate/checkasm-opusdsp.err for details.
> checkasm: using random seed 4190264620
> FMA3:
>  - opusdsp.postfilter_15   [OK]
>  - opusdsp.postfilter_512  [OK]
>  - opusdsp.postfilter_1022 [OK]
>  deemphasis_fma3 (fatal signal 11: Segmentation fault)
>  - opusdsp.deemphasis      [FAILED]
> checkasm: 1 of 4 tests have failed
> threads=1
> make: *** [tests/Makefile:311: fate-checkasm-opusdsp] Error 1
>

Forgot that I disabled asm to test with asan.
Fixed checkasm.
Patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4-0001-opusdsp-add-ability-to-modify-deemphasis-constant.patch
Type: text/x-diff
Size: 11355 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240425/0bcfb964/attachment.patch>