[FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header

[Kacper Michajlow]

On Fri, 9 Aug 2024 at 00:04, Jan Ekström <jeebjp at gmail.com> wrote:
>
> On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow <kasper93 at gmail.com> wrote:
> >
> > Fixes remaining \r\n is ASS header after 57c545090d.
> >
> > Signed-off-by: Kacper Michajłow <kasper93 at gmail.com>
> > ---
>
> With an initial look this set looks good. If I understand correctly,
> the generic ASS encoder moved to outputting LF only in
> 7bf1b9b35769b37684dd2f18a54f01d852a540c8 and thus these modules which
> still output manual headers with CRLF cause mismatching endlines
> within a single document.

This patchest indeed fixes mismatched endlines, but the main thing it fixes is
libzvbi_teletextdec converter which currently always returns
AVERROR_BUG, because default style no longer matches (after 7bf1b9b35)
the `strstr` expectation.
https://github.com/FFmpeg/FFmpeg/blob/c390234da2e3c7a8884f5592f0b9b4928c482b3e/libavcodec/libzvbi-teletextdec.c#L94

    event_pos = strstr(avctx->subtitle_header, "\r\n[Events]\r\n");
    if (!event_pos)
        return AVERROR_BUG;

- Kacper