[FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

[Christophe Gisquet]

Hi,

Le mar. 13 août 2024 à 23:39, Dale Curtis <dalecurtis at chromium.org> a écrit :
>
> On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>
> > Disabling random codec features seems like an anti-feature to me, in
> > the future it'll make every feature be questioned and compile-time
> > conditional, and make everything terrible.
> > If the context size is the major concern, maybe large structures
> > should be allocated when in use, rather than always?
> >
>
> I agree with that, so here's a version which allocates dynamically instead.
> It passes FATE, but I didn't try with valgrind/msan in case I missed a
> cleanup path.

(not an author)
Probably there is remaining work pending on external dependencies, but
H274FilmGrainDatabase sounds a bit adhoc. The 8KB of slice_tmp for one
could just be a local variable in init_slice(). The 676KB (!) of the
noise database are a bit more puzzling and could be the one that needs
allocating only when the noise is generated. It may simplify a bit
some of the conditions in this patch.

-- 
Christophe