[FFmpeg-devel] [PATCH v2] lavc/vvc: Remove assertions on qPy_{a, b}

Frank Plowman post at frankplowman.com
Sun Aug 25 14:50:41 EEST 2024


These assertions are not violated, even by illegal bitstreams.
Additionally, the upper bound should be <= 63, rather than < 63.

Signed-off-by: Frank Plowman <post at frankplowman.com>
---
Changes since v1
(https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240824092842.69365-1-post@frankplowman.com/):
* Remove the assertions entirely, rather than change the upper bound

 libavcodec/vvc/ctu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c
index 139d3dded5..70b0f05118 100644
--- a/libavcodec/vvc/ctu.c
+++ b/libavcodec/vvc/ctu.c
@@ -115,9 +115,6 @@ static int get_qp_y_pred(const VVCLocalContext *lc)
     else
         qPy_a = fc->tab.qp[LUMA][(x_cb - 1) + y_cb * min_cb_width];
 
-    av_assert2(qPy_a >= -fc->ps.sps->qp_bd_offset && qPy_a < 63);
-    av_assert2(qPy_b >= -fc->ps.sps->qp_bd_offset && qPy_b < 63);
-
     return (qPy_a + qPy_b + 1) >> 1;
 }
 
-- 
2.46.0



More information about the ffmpeg-devel mailing list