[FFmpeg-devel] [PATCH] avutil/timestamp: avoid using INFINITY for log10 result in av_ts_make_time_string2

[Kacper Michajlow]

On Wed, Aug 28, 2024, 07:56 Rémi Denis-Courmont <remi at remlab.net> wrote:

>
>
> Le 28 août 2024 06:29:30 GMT+03:00, Kacper Michajlow <kasper93 at gmail.com>
> a écrit :
> >On Tue, 27 Aug 2024 at 09:51, Rémi Denis-Courmont <remi at remlab.net>
> wrote:
> >>
> >>
> >>
> >> Le 27 août 2024 10:00:08 GMT+03:00, Marton Balint <cus at passwd.hu> a
> écrit :
> >>
> >> >IMHO the patch itself is harmless (simple, easy to follow), and if it
> helps somebody (no matter how unupported its use-case is), then why the
> hell not. But I can understand your point of view, that we should not
> bother with it, if it is unsupported in the first place, so I will just
> drop this, did not feel strongly about it anyway.
> >>
> >> Can't we just fail configure or compilation hard if
> __FINITE_MATH_ONLY__ is true?
> >>
> >> If MPV or whichever downstream wants to get this flag working, it's on
> them to do the hard work (and it's a lot harder than this patch).
> >
> >Whoa, don't call out mpv like that. There are no plans to do any of
> >that.
>
> Don't publicly accuse me of something I did not do. I don't remember who
> blamed this code for breaking mpv but it certainly wasn't me. And why the
> heck do you make it a problem now rather than then?
>

I don't know what you did or didn't do; I'm only responding to your mention
of mpv in this thread. If I'm missing some context outside this thread, I
apologize. I'm simply saying that mpv won't work with the mentioned flags
on its own, and I find it unnecessary to mention it as something that would
drive a change like that.

- Kacper