[FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb: add deinterleaveBytes neon implementation

[Michael Niedermayer]

On Fri, Aug 30, 2024 at 08:56:55PM +0200, Ramiro Polla wrote:
>                                       A55               A76
> deinterleave_bytes_c:             70342.0           34497.5
> deinterleave_bytes_neon:          21594.5 ( 3.26x)   5535.2 ( 6.23x)
> deinterleave_bytes_aligned_c:     71340.8           34651.2
> deinterleave_bytes_aligned_neon:   8616.8 ( 8.28x)   3996.2 ( 8.67x)
> ---
>  libswscale/aarch64/rgb2rgb.c      |  4 ++
>  libswscale/aarch64/rgb2rgb_neon.S | 59 +++++++++++++++++++++++
>  tests/checkasm/sw_rgb.c           | 77 +++++++++++++++++++++++++++++++
>  3 files changed, 140 insertions(+)

this breaks fate on x86-64

Test checkasm-sw_rgb failed. Look at tests/data/fate/checkasm-sw_rgb.err for details.
checkasm: using random seed 2852555319
SSE2:
 - sw_rgb.uyvytoyuv422       [OK]
 - sw_rgb.interleave_bytes   [OK]
   deinterleave_bytes_sse2 (fatal signal 11: Segmentation fault)
 - sw_rgb.deinterleave_bytes [FAILED]
 - sw_rgb.rgb_to_y           [OK]
 - sw_rgb.rgb_to_uv          [OK]
SSSE3:
 - sw_rgb.shuffle_bytes_2103 [OK]
 - sw_rgb.shuffle_bytes_0321 [OK]
 - sw_rgb.shuffle_bytes_1230 [OK]
 - sw_rgb.shuffle_bytes_3012 [OK]
 - sw_rgb.shuffle_bytes_3210 [OK]
 - sw_rgb.rgb_to_y           [OK]
 - sw_rgb.rgb_to_uv          [OK]
AVX:
 - sw_rgb.uyvytoyuv422       [OK]
   deinterleave_bytes_avx (fatal signal 11: Segmentation fault)
 - sw_rgb.deinterleave_bytes [FAILED]
 - sw_rgb.rgb_to_y           [OK]
 - sw_rgb.rgb_to_uv          [OK]
AVX2:
 - sw_rgb.shuffle_bytes_2103 [OK]
 - sw_rgb.shuffle_bytes_0321 [OK]
 - sw_rgb.shuffle_bytes_1230 [OK]
 - sw_rgb.shuffle_bytes_3012 [OK]
 - sw_rgb.shuffle_bytes_3210 [OK]
 - sw_rgb.uyvytoyuv422       [OK]
 - sw_rgb.rgb_to_y           [OK]
 - sw_rgb.rgb_to_uv          [OK]
checkasm: 2 of 179 tests have failed
threads=1
make: *** [tests/Makefile:311: fate-checkasm-sw_rgb] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240831/e9273992/attachment.sig>