[FFmpeg-devel] [PATCH 5/5] avformat/mov: dereference pointer after null check

Michael Niedermayer michael at niedermayer.cc
Thu Dec 12 05:39:42 EET 2024


Fixes: null pointer dereference
Fixes: 383397479/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4776829338058752

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/mov.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 5ed41f8ecd1..a69423f069b 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -10296,10 +10296,11 @@ static int mov_parse_tiles(AVFormatContext *s)
 
             for (k = 0; k < mov->nb_heif_item; k++) {
                 HEIFItem *item = mov->heif_item[k];
-                AVStream *st = item->st;
+                AVStream *st;
 
                 if (!item || item->item_id != tile_id)
                     continue;
+                st = item->st;
                 if (!st) {
                     av_log(s, AV_LOG_WARNING, "HEIF item id %d from grid id %d doesn't "
                                               "reference a stream\n",
-- 
2.47.0



More information about the ffmpeg-devel mailing list