[FFmpeg-devel] [PATCH 5/7] avformat/mpegts: add s337m support
Nicolas Gaullier
nicolas.gaullier at cji.paris
Thu Dec 12 14:54:29 EET 2024
>De : ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> de la part de Michael Niedermayer <michael at niedermayer.cc>
>Envoyé : lundi 9 décembre 2024 04:55
>
>/usr/bin/ld: libavformat/libavformat.so: undefined reference to `ff_reverse'
>
>thx
Sorry, I forgot to check build against --enable-shared...
Thanks to you.
I can fix this in a new patch serie, but the point is I don't know yet what form it should take...
It seems there is no proper way to support the current dolby_e decoder "as is" because of
the two red flags (nested decoders/resampler usage).
My guess is that the dolby_e decoder should be "extended" somehow to support all syncing scenarios,
including silence fallback with own code/not requiring a "full" resampler.
This is a significant work with some weird things like dealing with a truncated sample rate
and droping one sample from time to time to keep sync. And with no active
maintainer of the dolby_e decoder, so that won't help.
Well, it would be great if someone else took the job, but this is clearly too much for me.
Nevertheless, what could still remain is the s302m move from libavcodec to libavformat which is specifically
this patch.
But maybe this would sound void or odd because:
- it won't add any new feature for users
- the non_pcm_mode option would be dropped with no replacement
- the s302m decoder would be dropped, but not the s302m encoder
This is still possible and it actually is interresting to me, so I could send this PR and see,
but really, if you have a better idea or any advice on the best way to move on, please tell me!
Nicolas
More information about the ffmpeg-devel
mailing list