[FFmpeg-devel] [PATCH 02/14] avformat/flvdec: add support for demuxing multi-track FLV

Anton Khirnov anton at khirnov.net
Sat Dec 14 11:17:53 EET 2024


Quoting Timo Rothenpieler (2024-12-12 20:55:27)
> From: Dennis Sädtler <dennis at obsproject.com>
> 
> Based on enhanced-rtmp v2 spec published by Veovera:
> https://veovera.github.io/enhanced-rtmp/docs/enhanced/enhanced-rtmp-v2
> 
> Signed-off-by: Dennis Sädtler <dennis at obsproject.com>
> ---
>  libavformat/flvdec.c | 117 +++++++++++++++++++++++++++++++++++--------
>  1 file changed, 96 insertions(+), 21 deletions(-)

This could use some adapting to our coding style.

> @@ -1526,6 +1591,16 @@ retry_duration:
>              flv->new_extradata[stream_type]      = NULL;
>              flv->new_extradata_size[stream_type] = 0;
>          }
> +    } else if (multitrack
> +               && flv->mt_extradata_cnt > track_idx
> +               && flv->mt_extradata[track_idx]) {
> +        int ret = av_packet_add_side_data(pkt, AV_PKT_DATA_NEW_EXTRADATA,
> +                                          flv->mt_extradata[track_idx],
> +                                          flv->mt_extradata_sz[track_idx]);
> +        if (ret >= 0) {

This should fail when ret < 0

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list