[FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

[Ramiro Polla]

On Tue, Dec 17, 2024 at 4:02 AM Leo Izen <leo.izen at gmail.com> wrote:
> On 12/16/24 5:50 PM, Michael Niedermayer wrote:
> >
> > (c): implement enough of zlib ourselfs, so it can encode to a valid output
>
> A reimplementation of zlib that does nothing except for fixing FATE
> failures that shouldn't be failing anyway sounds like a security
> vulnerability waiting to happen. Stock maddler's zlib still has
> vulnerabilities occur and there's the whole world's eyes on it. This
> sounds like a bad idea.

I think the keyword from "implement enough of zlib ourselfs" is
"enough", in this case for uncompressed data. IIRC it's just 5 bytes +
uncompressed data for each chunk, which should be pretty simple.

I also don't think we should aim to reimplement zlib.