[FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

[James Almer]

On 12/16/2024 8:00 AM, Peter Ross wrote:
> since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c
> depends on golomb vlc tables.
> ---
> i often build with --disable-all and only turn on the components
> that i am working on. this dependency would otherwise go unnoticed since
> many codecs drag in golomb.
> 
>   configure | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index bf55ba67fa..751506cd6a 100755
> --- a/configure
> +++ b/configure
> @@ -2880,6 +2880,7 @@ h264parse_select="golomb"
>   h264_sei_select="atsc_a53 golomb"
>   hevcparse_select="golomb"
>   hevc_sei_select="atsc_a53 golomb"
> +iso_writer_select="golomb"
>   frame_thread_encoder_deps="encoders threads"
>   iamfdec_deps="iamf"
>   iamfdec_select="iso_media mpeg4audio"

This doesn't work for shared builds. You need to add golomb_tab.c to 
OBJS-$(CONFIG_ISO_WRITER) in libavformat/Makefile.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241218/75b5dc1c/attachment.sig>