[FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

[Vittorio Giovara]

On Wed, Dec 18, 2024 at 12:48 PM Ronald S. Bultje <rsbultje at gmail.com>
wrote:

> >
> > It is worth pointing out that *libswscale* does not directly output PAL8;
> > this rather is (and always was) handled by vf_scale. So in some sense,
> this
> > functionality already depends on libavfilter.
> >
> > That said, I do agree that simply regressing existing use cases should
> not
> > be done without some sort of mechanism for automatically invoking the
> > proper
> > replacement.
> >
> > I will retract this patch for now, then, and put the corresponding issue
> on
> > hold. I think that a full discussion of how to handle this better will
> have
> > to wait until we have a better dither handling inside swscale.
> >
>
> I would commit it, but instead of failing, emit a warning (recommending to
> use the palettegen filter instead) and continue the old behaviour (as a
> fallback).
>
> Upon the next major bump, the warning will become an error and the fallback
> is removed.
>

+1
-- 
Vittorio