[FFmpeg-devel] [PATCH 1/5] hwcontext_vulkan: disable validation layer threading warnings

[Koushik Dutta]

I am not seeing the previous commit to this file in the mailing list
so I'm not sure what to respond to. The previous commit broke the
build on Windows as it results in an empty array:

commit 18af3a1db2db07cd24d611cc9cdc86fcdec4b505
Author: Lynne <dev at lynne.ee>
Date:   Wed Dec 18 13:14:27 2024 +0900

    hwcontext_vulkan: do not enable portability subset by default

    It doesn't make sense to, and could result in the implementation
    picking emulation layers.

diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
index e379642cd3..5601ef4d9e 100644
--- a/libavutil/hwcontext_vulkan.c
+++ b/libavutil/hwcontext_vulkan.c
@@ -573,7 +573,9 @@ typedef struct VulkanOptExtension {
 } VulkanOptExtension;

 static const VulkanOptExtension optional_instance_exts[] = {
+#ifdef __APPLE__
     { VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME,
FF_VK_EXT_NO_FLAG                },
+#endif
 };


The build error:

libavutil/hwcontext_vulkan.c(588): error C2059: syntax error: '}'

On Wed, Dec 18, 2024 at 12:16 AM Lynne via ffmpeg-devel
<ffmpeg-devel at ffmpeg.org> wrote:
>
> The layer is buggy currently:
> https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/9045
> ---
>  libavutil/hwcontext_vulkan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
> index 5601ef4d9e..6eca097ea3 100644
> --- a/libavutil/hwcontext_vulkan.c
> +++ b/libavutil/hwcontext_vulkan.c
> @@ -626,6 +626,7 @@ static VkBool32 VKAPI_CALL vk_dbg_callback(VkDebugUtilsMessageSeverityFlagBitsEX
>      case 0xfd92477a: /* BestPractices-vkAllocateMemory-small-allocation */
>      case 0x618ab1e7: /* VUID-VkImageViewCreateInfo-usage-02275 */
>      case 0x30f4ac70: /* VUID-VkImageCreateInfo-pNext-06811 */
> +    case 0xa05b236e: /* UNASSIGNED-Threading-MultipleThreads-Write */
>          return VK_FALSE;
>      default:
>          break;
> --
> 2.45.2
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".