[FFmpeg-devel] [PATCH 4/4] avformat/mlvdec: Check avio_read()
Michael Niedermayer
michael at niedermayer.cc
Wed Dec 25 06:26:57 EET 2024
Fixes: use-of-uninitialized-value
Fixes: 383170476/clusterfuzz-testcase-minimized-ffmpeg_dem_MLV_fuzzer-4696002884337664
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavformat/mlvdec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c
index 1a6d38f37cb..985365326e8 100644
--- a/libavformat/mlvdec.c
+++ b/libavformat/mlvdec.c
@@ -82,13 +82,15 @@ static int check_file_header(AVIOContext *pb, uint64_t guid)
static void read_string(AVFormatContext *avctx, AVIOContext *pb, const char *tag, unsigned size)
{
char * value = av_malloc(size + 1);
+ int ret;
+
if (!value) {
avio_skip(pb, size);
return;
}
- avio_read(pb, value, size);
- if (!value[0]) {
+ ret = avio_read(pb, value, size);
+ if (ret != size || !value[0]) {
av_free(value);
return;
}
--
2.47.0
More information about the ffmpeg-devel
mailing list