[FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

[Leo Izen]

On 12/26/24 6:12 PM, J Shiff wrote:
> On Wed, Dec 25, 2024 at 5:03 PM Alexander Strasser via ffmpeg-devel
> <ffmpeg-devel at ffmpeg.org> wrote:
>>
>> On 2024-12-21 19:29 -0500, J Shiff wrote:
>>> On Sat, Dec 21, 2024 at 5:44 PM Alexander Strasser via ffmpeg-devel
>>> <ffmpeg-devel at ffmpeg.org> wrote:
>>>>
>>>> On 2024-12-16 16:19 -0500, Joe Schiffler wrote:
>>>>> Since $pkg_version includes spaces, builds can fail in some MSYS environments.
>>>>
>>>> Could you show what the pkg_version with spaces was in your case?
>>>
>>> The value of pkg_version would be: `aom >= 2.0.0`
>>
>> Ok, thanks for coming back to this!
>>
>> What is still strange about it: What changed and where?
>>
>> These values for pkg_version should come up on every platform
>> and AFAICT it works just fine for me and many others.
>>
>> Didn't spot any relevant changes in ffmpeg configure on a quick
>> look.
>>
>> Would be better to understand why it fails only in some
>> environments and not others.
> 
> Thank you for showing interest in this topic.
> 
> Yeah, I also find it strange.
> If you have any recommendations for narrowing it down further, I'm
> open to suggestions.
> 

I did a bit of testing and I believe the issue is >=, specifically, it's 
being interpreted as a redirect-out to a file named "=". pkg-config 
works on my system if I run `pkg-config --libs 'aom >= 2.0'` but also it 
works if I run `pkg-config --libs aom '>=' 2.0` but if I don't quote the 
redirect, the shell expands it.

I could not say why MSYS appears to be interpreting the redirect 
differently when expanding the variable, but if I had to guess, it may 
be a bug in its path-mangling (i.e. converting /foo/bar to C:\foo\bar) 
where it's interpreting "=" as a filename. I could not say for certain 
if this is the case.

In either case, I don't see issue with quoting it as that works on every 
system.

- Leo Izen (Traneptora)