[FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test

[Rémi Denis-Courmont]

Le 2 février 2024 01:42:20 GMT+02:00, Michael Niedermayer <michael at niedermayer.cc> a écrit :
>On Wed, Jan 31, 2024 at 08:00:18PM +0800, flow gg wrote:
>> 
>
>>  checkasm/Makefile   |    1 
>>  checkasm/checkasm.c |    3 ++
>>  checkasm/checkasm.h |    1 
>>  checkasm/rv34dsp.c  |   65 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  fate/checkasm.mak   |    1 
>>  5 files changed, 71 insertions(+)
>> e7eed6e25de9f313ddb3c0f3066f02f0671d3271  0001-checkasm-rv34dsp-add-rv34_inv_transform_dc-test.patch
>> From 46a81051f49f6b4032815d5f123be8ff614033e2 Mon Sep 17 00:00:00 2001
>> From: sunyuechi <sunyuechi at iscas.ac.cn>
>> Date: Wed, 31 Jan 2024 19:00:23 +0800
>> Subject: [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test
>
>seems to fail here

Do you mean that the test is wrong or that it exposes a bug in the x86 optimisations (which wouldn't be the first occurrence)?

It's painful enough that RVV optimisations need to add checkasm tests for existing code. We can't be expected to fix x86 bugs on top.