[FFmpeg-devel] [PATCH v2] lavc/dxvenc: fix failing FATE tests

Connor Worley connorbworley at gmail.com
Fri Feb 9 11:11:43 EET 2024


Prevents access to uninitialized parts of ctx->tex_data, which were
causing FATE tets to fail under valgrind with --malloc-fill set.

Signed-off-by: Connor Worley <connorbworley at gmail.com>
---
 libavcodec/dxvenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/dxvenc.c b/libavcodec/dxvenc.c
index ebc48aace3..b92d99981c 100644
--- a/libavcodec/dxvenc.c
+++ b/libavcodec/dxvenc.c
@@ -234,7 +234,7 @@ static av_cold int dxv_init(AVCodecContext *avctx)
                     ctx->enc.tex_ratio;
     ctx->enc.slice_count = av_clip(avctx->thread_count, 1, FFALIGN(avctx->height, 16) / TEXTURE_BLOCK_H);

-    ctx->tex_data = av_malloc(ctx->tex_size);
+    ctx->tex_data = av_mallocz(ctx->tex_size);
     if (!ctx->tex_data) {
         return AVERROR(ENOMEM);
     }
--
2.40.1


More information about the ffmpeg-devel mailing list