[FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Feb 13 11:28:26 EET 2024


flow gg:
> Subject: [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp
> 
> This asm will cause checkasm to fail.
> ---
>  libavcodec/x86/rv34dsp.asm    | 12 ------------
>  libavcodec/x86/rv34dsp_init.c |  2 --

Of course your checkasm test will fail: You used declare_func and not
declare_func_emms for this. Using the latter means "the tested function
is expected to clobber the mmx state"; otherwise clobbering MMX is
considered an error.

- Andreas



More information about the ffmpeg-devel mailing list