[FFmpeg-devel] [PATCH 3/5] avformat/iamf_writer: Don't memset twice

James Almer jamrial at gmail.com
Mon Feb 19 23:57:31 EET 2024


On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote:
> This has been allocated via av_calloc() a few lines above.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>   libavformat/iamf_writer.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c
> index e0c47b5e9d..9a665dc002 100644
> --- a/libavformat/iamf_writer.c
> +++ b/libavformat/iamf_writer.c
> @@ -251,7 +251,6 @@ int ff_iamf_add_audio_element(IAMFContext *iamf, const AVStreamGroup *stg, void
>           int nb_channels = iamf_audio_element->layers[i]->ch_layout.nb_channels;
>   
>           IAMFLayer *layer = &audio_element->layers[i];
> -        memset(layer, 0, sizeof(*layer));
>   
>           if (i)
>               nb_channels -= iamf_audio_element->layers[i - 1]->ch_layout.nb_channels;

LGTM


More information about the ffmpeg-devel mailing list