[FFmpeg-devel] [PATCH v2 5/6] avformat/iamf_writer: Return proper error codes

[James Almer]

On 2/19/2024 7:17 PM, Andreas Rheinhardt wrote:
> Surprisingly the return value of add_param_definition()
> (a pointer) has only been used to check for success
> and not to actually access the pointee; nonsuccess
> was equated with ENOMEM, although there is a non-enomem
> error path in this function.
> 
> Change this by returning an int.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> Maybe one should avoid the param_definition variables entirely
> by using if (!ff_iamf_get_param_definition(...))?

Sure, either way (this patch or this suggestion) is fine.