[FFmpeg-devel] [PATCH v4 0/4] Fix some active sequences in subtitles

Oneric oneric at oneric.de
Tue Feb 27 00:26:38 EET 2024


ping

I forgot to again add a description to v4 so:
These small patches fix several mis-conversions for subtitles
(and additionally one cde cleanup in avcodec/ass.c):

 - WebVTT files no longer get their BiDi marks stripped
   (which mangled BiDi text)
 - backslashes are no longer duplicated for no reason
 - ffmpeg’s attempt at escaping curly braces no longer
   severly breaks in standard ASS renderers

v1 was posted over 2 years ago, would be great
if someone could finally look at this


On Mon, Feb 19, 2024 at 22:42:23 +0100, Oneric wrote:
> Changes from v3:
>  - None.  Just rebased ontop of master to allow
>    Patchwork to properly process the series now
>    that 99d33cc661fbd04e8657831 was merged.
> 
> Changes from v2:
>  - rebased ontop of the recently pushed eol normalisation.
>    As a result no more CRLFs in here and Patchwork should be happy
>  - added a fourth cosmetic commit adjusting
>    explicit linebreaks to the new normalisation
> 
> Changes from v1:
>  - ff_ass_bprint_text_event now only inserts a word-joiner
>    if there isn’t already one anyway
>  - added a third commit improving the handling of
>    curly brackets for standard ASS renderers
> 
> Oneric (4):
>   avcodec/webvttdec: honour bidi marks
>   avcodec/{ass,webvttdec}: fix handling of backslashes
>   avcodec/{ass,webvttdec}: more portable curly brace escapes
>   avocdec/ass: simplify linebreaks
> 
>  libavcodec/ass.c           | 47 +++++++++++++++++++++++---------------
>  libavcodec/webvttdec.c     |  4 ++--
>  tests/ref/fate/sub-webvtt  |  2 +-
>  tests/ref/fate/sub-webvtt2 |  2 +-
>  4 files changed, 33 insertions(+), 22 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240226/c954796a/attachment.sig>


More information about the ffmpeg-devel mailing list