[FFmpeg-devel] 回复: [PATCH 1/2] avcodec/d3d12va_mpeg2: remove unused variables

Wu Jianhua toqsxw at outlook.com
Mon Jan 1 11:48:57 EET 2024


James Almer:
> [FFmpeg-devel] [PATCH 1/2] avcodec/d3d12va_mpeg2: remove unused variables
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> is_field worries me. Was it a copy-paste left over, or is it meant to
> be checked?
>
> libavcodec/d3d12va_mpeg2.c | 8 --------
> 1 file changed, 8 deletions(-)

> diff --git a/libavcodec/d3d12va_mpeg2.c b/libavcodec/d3d12va_mpeg2.c
> index 91bf3f8b75..a2ae8bf948 100644
> --- a/libavcodec/d3d12va_mpeg2.c
> +++ b/libavcodec/d3d12va_mpeg2.c
> @@ -49,7 +49,6 @@ static int d3d12va_mpeg2_start_frame(AVCodecContext *avctx, av_unused const uint
>     const MpegEncContext      *s       = avctx->priv_data;
>     D3D12VADecodeContext      *ctx     = D3D12VA_DECODE_CONTEXT(avctx);
>     D3D12DecodePictureContext *ctx_pic = s->current_picture_ptr->hwaccel_picture_private;
>-    DXVA_QmatrixData          *qm      = &ctx_pic->qm;
>
>     if (!ctx)
>         return -1;
>@@ -76,8 +75,6 @@ static int d3d12va_mpeg2_decode_slice(AVCodecContext *avctx, const uint8_t *buff
>     const MpegEncContext      *s       = avctx->priv_data;
>     D3D12DecodePictureContext *ctx_pic = s->current_picture_ptr->hwaccel_picture_private;
>
> -    int is_field = s->picture_structure != PICT_FRAME;
> -
> 

This patch set LGTM. It's something added for debugging but forgot to remove. Thanks for your fix.


More information about the ffmpeg-devel mailing list