[FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

Michael Niedermayer michael at niedermayer.cc
Fri Jan 5 22:47:13 EET 2024


On Fri, Jan 05, 2024 at 01:55:08PM +0200, Martin Storsjö wrote:
> On Thu, 4 Jan 2024, James Almer wrote:
> 
> > On 1/4/2024 10:57 AM, Nuo Mi wrote:
> > > On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö <martin at martin.st> wrote:
> > > 
> > > > On Thu, 4 Jan 2024, Nuo Mi wrote:
> > > > 
> > > > > On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer <
> > > > michael at niedermayer.cc>
> > > > > wrote:
> > > > > 
> > > > > > On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote:
> > > > > > [...]
> > > > > > > maintainer, and any HEVC code change requires a very long review time.
> > > > > > 
> > > > > > I think changes that just move code around or rename functions would be
> > > > > > quickly reviewed
> > > > > > I dont know if things are 1:1 identical or some complex changes are
> > > > needed
> > > > > > 
> > > > > > I think if things are 1:1 identical it can be done now otherwise it may
> > > > be
> > > > > > better to do after the initial merge
> > > > > > 
> > > > > Agree,
> > > > > 
> > > > > Taking   https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10404
> > > > as
> > > > > an example,
> > > > > The following items are worth discussing, though they won't impact the
> > > > > functionality:
> > > > > 1. Can we use "XVC" as a common name for HEVC and VVC, or should we use
> > > > > "h2656" instead of "XVC"?
> > > > 
> > > > The name "xvc" is potentially confusing - there is another video codec
> > > > with the name xvc as well - see https://xvc.io.
> > > > 
> > > Yes, it's been dead for 4 years :). https://github.com/divideon/xvc
> > > Not sure if the new codec will be named as xvc or not.
> > > h2656 is safer but ugly
> > 
> > How about h26x? h264 also shares some code with hevc and vvc, like the
> > NALu splitting code.
> 
> h264x looks clearer, not that ugly, and less ambiguous to me, so that sounds
> reasonable to me.

i agree
there h261, h262/mpeg2, h263/mpeg4
it would be better for clarity if these groups can be distinguished from their
names or location

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240105/28e720e1/attachment.sig>


More information about the ffmpeg-devel mailing list