[FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg_demux: replace abort() by av_assert0(0)

Stefano Sabatini stefasab at gmail.com
Sat Jan 6 13:18:08 EET 2024


On date Friday 2024-01-05 17:42:44 +0100, Anton Khirnov wrote:
> This is the standard way to mark unreachable cases in a switch
> ---
>  fftools/ffmpeg_demux.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index 95af31e9ef..5d07b7153d 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1223,8 +1223,7 @@ static int ist_add(const OptionsContext *o, Demuxer *d, AVStream *st)
>      case AVMEDIA_TYPE_ATTACHMENT:
>      case AVMEDIA_TYPE_UNKNOWN:
>          break;
> -    default:
> -        abort();
> +    default: av_assert0(0);

LGTM, also probably we might employ a self-documentation trick of the
kind:
av_assert0(!"handled media type");


More information about the ffmpeg-devel mailing list