[FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

Stefano Sabatini stefasab at gmail.com
Sun Jan 7 14:05:32 EET 2024


On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote:
[...] 
> I'm not blocking the patch, however, I'm not sure whether the gain
> outweighs the effort for such large code changes.  It's very
> unlikely to introduce new issues, but possible (e.g., typo while do
> copy paste), and it's hard to check while review.

It's true that it's hard to review, but in case of typos we should
notice almost immediately (e.g. because compilation fails).

And the readability boost it gives (sorted options means you don't
need to read through all the options to find a given one) is well
worth it.


More information about the ffmpeg-devel mailing list