[FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

[Gyan Doshi]

On 2024-01-08 08:23 am, Zhao Zhili wrote:
>
>> On Jan 7, 2024, at 20:05, Stefano Sabatini <stefasab at gmail.com> wrote:
>>
>> On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote:
>> [...]
>>> I'm not blocking the patch, however, I'm not sure whether the gain
>>> outweighs the effort for such large code changes.  It's very
>>> unlikely to introduce new issues, but possible (e.g., typo while do
>>> copy paste), and it's hard to check while review.
>> It's true that it's hard to review, but in case of typos we should
>> notice almost immediately (e.g. because compilation fails).
> Typo doesn’t always lead to compilation fail, especially in AVOption
> tables.

In this case, patchwork shows fate passing, so there's no meaningful 
typos, if any.

This change improves 'scanability', so LGTM.

Regards,
Gyan