[FFmpeg-devel] Initial tickering at unifying ProRes encoder

[Clément Bœsch]

On Sun, Dec 24, 2023 at 11:56:56AM +0100, Stefano Sabatini wrote:
> On date Monday 2023-12-11 02:35:01 +0100, Clément Bœsch wrote:
> > Hello there,
> > 
> > I'm currently investigating an issue¹ affecting Kostya ProRes encoder
> > which is not reproducible with Anatoliy encoder (but it's too early to
> > say if the bug is not present there as well given the differences in
> > quantization, and it's also unclear if the issue is even actually
> > there in the first place and not in M2/M3 firmwares).
> > 
> > Since these encoders share more than similiarities, I've been looking
> > into their differences, and unifying their common codepaths was helpful
> > to my investigation.
> > 
> > Attached is an initial patchset working out their differences by either
> > sharing data or making code identical where relevant.
> > 
> > I will continue that work as the investigation progresses. The
> > quantization work might require more involved changes though.
> > 
> > Regards,
> > 
> > ¹ https://trac.ffmpeg.org/ticket/10255
> 
> Hi Clement.
> 
> Most patches look good to me. You can skip style comments in patches
> 3, 4, 15 if they complicate the rebase.

Patchset applied; I skipped the 2 out of the 3 cosmetics

Thank you for the review

-- 
Clément B.