[FFmpeg-devel] [PATCH v2] checkasm/hevc_deblock: add luma and chroma full

[Michael Niedermayer]

On Wed, Jan 24, 2024 at 01:06:34PM +0100, J. Dekker wrote:
> Signed-off-by: J. Dekker <jdek at itanimul.li>
> ---
>  tests/checkasm/hevc_deblock.c | 225 +++++++++++++++++++++++++++++-----
>  1 file changed, 195 insertions(+), 30 deletions(-)
> 
> - added luma 10/12 bit
> - supporting full (*_c) luma & chroma functions
> - dynamically generating all test data
> 
> Appears to work for me. Testing on x86, hits the filtering decisions correctly.
> x86 doesn't have the full asm functions though, need to check a platform which
> has them (though the difference is minor, not sure why it wouldn't work).

I see intermittend failures on x86-64 linux

make V=2 fate-checkasm-hevc_deblock

TEST    checkasm-hevc_deblock
./tests/fate-run.sh fate-checkasm-hevc_deblock "fate-suite/" "" "" 'run tests/checkasm/checkasm --test=hevc_deblock' 'null' '' '' '1' '' '' '' '' '' '' '' '' '' ''
 /tests/checkasm/checkasm --test=hevc_deblock

 $ make V=2 fate-checkasm-hevc_deblock
...
TEST    checkasm-hevc_deblock
./tests/fate-run.sh fate-checkasm-hevc_deblock "fate-suite/" "" "" 'run tests/checkasm/checkasm --test=hevc_deblock' 'null' '' '' '1' '' '' '' '' '' '' '' '' '' ''
 /tests/checkasm/checkasm --test=hevc_deblock
Test checkasm-hevc_deblock failed. Look at tests/data/fate/checkasm-hevc_deblock.err for details.
checkasm: using random seed 241122653
SSE2:
 - hevc_deblock.chroma [OK]
   hevc_h_loop_filter_luma12_weak_sse2 (hevc_deblock.c:230)
 - hevc_deblock.luma   [FAILED]
SSSE3:
 - hevc_deblock.luma   [OK]
AVX:
 - hevc_deblock.chroma [OK]
 - hevc_deblock.luma   [OK]
checkasm: 1 of 66 tests have failed
threads=1
tests/Makefile:318: recipe for target 'fate-checkasm-hevc_deblock' failed
make: *** [fate-checkasm-hevc_deblock] Error 1



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240125/fda84cd3/attachment.sig>