[FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device

[Stefano Sabatini]

On date Wednesday 2024-01-24 08:47:52 +0100, Anton Khirnov wrote:
> Quoting Stefano Sabatini (2024-01-16 00:58:02)
> > ---
> >  fftools/opt_common.c | 28 +++++++++++++++++++++-------
> >  1 file changed, 21 insertions(+), 7 deletions(-)
> > 
> > diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> > index f5b73c9f2f..e263a5297e 100644
> > --- a/fftools/opt_common.c
> > +++ b/fftools/opt_common.c
> > @@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
> >      const char *last_name;
> >      int is_dev;
> >  
> > -    printf("%s\n"
> > -           " D. = Demuxing supported\n"
> > -           " .E = Muxing supported\n"
> > -           " --\n", device_only ? "Devices:" : "File formats:");
> > +    if (device_only) {
> > +        printf("Devices:\n"
> > +               " D. = Demuxing supported\n"
> > +               " .E = Muxing supported\n"
> > +               " --\n");
> > +    } else {
> > +        printf("Formats:\n"
> > +               " D.. = Demuxing supported\n"
> > +               " .E. = Muxing supported\n"
> > +               " ..d = Is a device\n"
> > +               " ---\n");
> 
> I don't like this duplication.

will apply with the code re-factored