[FFmpeg-devel] [PATCH] lavc/bsf: add a showinfo filter

Anton Khirnov anton at khirnov.net
Tue Jan 30 11:11:52 EET 2024


Quoting Andreas Rheinhardt (2024-01-30 08:17:23)
> > +#include <stdint.h>
> 
> You should use inttypes.h instead -- it provides everything stdint.h
> provides and the print directive defines like PRId64.
> 
> > +static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
> > +{
> > +    ShowinfoContext *priv = ctx->priv_data;
> > +
> > +    while (1) {
> 
> This loop will only ever be executed once and should be removed.

Right, both done locally.

Thanks,
-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list