[FFmpeg-devel] [PATCH 3/7 v2] avformat/mov: make MOVStreamContext refcounted

[Michael Niedermayer]

On Tue, Jan 30, 2024 at 02:32:14PM -0300, James Almer wrote:
> This will be needed by the following commit.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavformat/mov.c | 257 ++++++++++++++++++++++++++--------------------
>  1 file changed, 145 insertions(+), 112 deletions(-)

The previous commits dont seem to build alone

libavformat/mov.c: In function ‘heif_add_stream’:
libavformat/mov.c:4931:60: error: ‘mov_free_stream_context’ undeclared (first use in this function); did you mean ‘ff_find_stream_index’?
     buf = av_buffer_create(data, sizeof(MOVStreamContext), mov_free_stream_context, c->fc, 0);
                                                            ^~~~~~~~~~~~~~~~~~~~~~~
                                                            ff_find_stream_index
libavformat/mov.c:4931:60: note: each undeclared identifier is reported only once for each function it appears in
libavformat/mov.c:4942:10: error: implicit declaration of function ‘mov_get_stream_context’; did you mean ‘ffio_init_read_context’? [-Werror=implicit-function-declaration]
     sc = mov_get_stream_context(st);

And with this commit also not:

    libavcodec/libavcodec.a(bitstream_filters.o):(.data.rel.ro+0x90): undefined reference to `ff_iamf_stream_split_bsf'
collect2: error: ld returned 1 exit status
Makefile:133: recipe for target 'ffmpeg_g' failed
make: *** [ffmpeg_g] Error 1

the next builds


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240131/554c7ee5/attachment.sig>