[FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio

[Lynne]

On 01/07/2024 01:12, Michael Niedermayer wrote:
> Fixes: CID1605475 Logically dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>   libavcodec/aac/aacdec_usac.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
> index 9587348021e..10121dbc34f 100644
> --- a/libavcodec/aac/aacdec_usac.c
> +++ b/libavcodec/aac/aacdec_usac.c
> @@ -1676,9 +1676,6 @@ int ff_aac_usac_decode_frame(AVCodecContext *avctx, AACDecContext *ac,
>       } else if (sbr_ratio == 3) {
>           ratio_mult = 2;
>           ratio_dec = 1;
> -    } else if (sbr_ratio == 4) {
> -        ratio_mult = 4;
> -        ratio_dec = 1;
>       } else {
>           ratio_mult = 1;
>           ratio_dec = 1;

Its valid, just not supported at the moment. Maybe just error out with 
PATCHWELCOME?
Or mark it as a false positive?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240703/70b7b4a7/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240703/70b7b4a7/attachment.sig>