[FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

[Michael Niedermayer]

On Wed, Jul 03, 2024 at 02:05:06PM -0700, Josh Allmann wrote:
> Encoders may emit a buffering period SEI without a corresponding
> SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc.
> 
> During Annex B conversion, this may result in the SPS/PPS being
> inserted *after* the buffering period SEI but before the IDR NAL.
> 
> Since the buffering period SEI references the SPS, the SPS/PPS
> needs to come first.
> ---
>  libavcodec/bsf/h264_mp4toannexb.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

breaks fate

TEST    h264-bsf-mp4toannexb
--- ./tests/ref/fate/h264-bsf-mp4toannexb	2024-07-01 23:30:40.656213791 +0200
+++ tests/data/fate/h264-bsf-mp4toannexb	2024-07-06 12:13:56.491072296 +0200
@@ -1 +1 @@
-5f04c27cc6ee8625fe2405fb0f7da9a3
+ff2551123909f54c382294baa1bb4364
Test h264-bsf-mp4toannexb failed. Look at tests/data/fate/h264-bsf-mp4toannexb.err for details.
make: *** [tests/Makefile:311: fate-h264-bsf-mp4toannexb] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240706/62405eef/attachment.sig>