[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: use a bprint buffer for the crop filter arguments

[James Almer]

Should ensure no truncation ocurrs.

The input sample aspect ratio applies to the pre-cropping dimensions, so update it.

Signed-off-by: James Almer <jamrial at gmail.com>
---
 fftools/ffmpeg_filter.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 097bd2ed48..bb88c6711a 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -1702,12 +1702,12 @@ static int configure_input_video_filter(FilterGraph *fg, AVFilterGraph *graph,
     av_assert0(desc);
 
     if ((ifp->opts.flags & IFILTER_FLAG_CROP)) {
-        char crop_buf[64];
-        snprintf(crop_buf, sizeof(crop_buf), "w=iw-%d-%d:h=ih-%d-%d:x=%d:y=%d",
+        av_bprint_clear(&args);
+        av_bprintf(&args, "w=iw-%d-%d:h=ih-%d-%d:x=%d:y=%d",
                  ifp->opts.crop_left, ifp->opts.crop_right,
                  ifp->opts.crop_top, ifp->opts.crop_bottom,
                  ifp->opts.crop_left, ifp->opts.crop_top);
-        ret = insert_filter(&last_filter, &pad_idx, "crop", crop_buf);
+        ret = insert_filter(&last_filter, &pad_idx, "crop", args.str);
         if (ret < 0)
             return ret;
     }
-- 
2.45.2