[FFmpeg-devel] [PATCH] x86/intreadwrite: add missing casts to pointer arguments

[Martin Storsjö]

On Thu, 11 Jul 2024, James Almer wrote:

> Should make strict compilers happy.
> Also, make AV_COPY128 use integer operations while at it.
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> libavutil/x86/intreadwrite.h | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/libavutil/x86/intreadwrite.h b/libavutil/x86/intreadwrite.h
> index d916410e14..65cc6b39a1 100644
> --- a/libavutil/x86/intreadwrite.h
> +++ b/libavutil/x86/intreadwrite.h
> @@ -23,32 +23,25 @@
>
> #include <stdint.h>
> #include "config.h"
> -#if HAVE_INTRINSICS_SSE && defined(__SSE__)
> -#include <immintrin.h>
> -#endif

If we no longer use HAVE_INTRINSICS_SSE, should we remove the 
corresponding check in configure too?

Thanks, this patch seems to avoid the issue discussed in the other thread. 
(I'm not familiar enough with these intrinsics to be able to comment 
meaningfully on the patch itself though.)

// Martin