[FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

[James Almer]

On 7/12/2024 4:34 PM, Michael Niedermayer wrote:
> On Fri, Jul 12, 2024 at 01:57:43PM -0300, James Almer wrote:
>> On 7/12/2024 1:53 PM, Michael Niedermayer wrote:
>>> On Thu, Jul 11, 2024 at 01:31:23PM +0000, James Almer wrote:
>>>> ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Mon Jul  8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer
>>>>
>>>> avformat/mov: export cropping values from clap boxes
>>>>
>>>> Addresses part of ticket #7437.
>>>>
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>>
>>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=93be6b425ebeb6cf96faf502281a4f7a1ed5138c
>>>> ---
>>>>
>>>>    libavformat/mov.c                       | 74 +++++++++++++++++++++++++++++++++
>>>>    tests/ref/fate/aic                      | 32 +++++++-------
>>>>    tests/ref/fate/prores-transparency      |  4 +-
>>>>    tests/ref/fate/prores-transparency_skip |  4 +-
>>>>    4 files changed, 94 insertions(+), 20 deletions(-)
>>>
>>> breaks:
>>>
>>> ./ffmpeg_g -i ~/tickets/1439/in.mov -t 1 -timecode 09:59:30:06 -an -c:v dvvideo -pix_fmt yuv420p -an -y -bitexact /tmp/ile1439.mov
>>>
>>> [dvvideo @ 0x7fd2d8011980] Found no DV profile for 702x576 yuv420p video. Valid DV profiles are:
>>
>> The input file has a clap box that defines cropping, which began being
>> applied by default after the aforementioned commit.
> 
> I did realize that, i reported that anyway as it was a interresting failure
> 
> 
>> You should add
>> "-apply_cropping 0" to disable all cropping or "-apply_cropping 2" to only
>> apply codec level cropping.
> 
> thx ill use that

All values for apply_cropping are documented in ffmpeg.texi. It used to 
be a bool but now it also accepts 2 and 3 (And const aliases for all 
four values).

I wouldn't use 0 in general, before or after the above commit, as codec 
level cropping is almost always desirable (1080p h264 samples would 
decode as 1088 lines otherwise, for example), so IMO use 2/codec to 
disable container cropping and only leave codec cropping on for this 
kind of scenario.