[FFmpeg-devel] [PATCH 12/39] lavc/ffv1: drop redundant FFV1Context.quant_table

Michael Niedermayer michael at niedermayer.cc
Thu Jul 18 01:37:25 EEST 2024


On Tue, Jul 16, 2024 at 07:11:27PM +0200, Anton Khirnov wrote:
> In all cases except decoding version 1 it's either not used, or contains
> a copy of a table from quant_tables, which we can just as well use
> directly.
> 
> When decoding version 1, we can just as well decode into
> quant_tables[0], which would otherwise be unused.
> ---
>  libavcodec/ffv1.h    |  1 -
>  libavcodec/ffv1dec.c | 10 +++++++---
>  libavcodec/ffv1enc.c |  6 ++----
>  3 files changed, 9 insertions(+), 8 deletions(-)

the code is 1 line longer and using the first entry as a special
case doesnt seem simpler

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240718/1781cd45/attachment.sig>


More information about the ffmpeg-devel mailing list