[FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

[Peter Ross]

On Sat, Jul 20, 2024 at 10:19:18AM -0400, Aaron wrote:
>  On Fri, Jul 19, 2024 at 07:54:37PM -0400, Peter Ross wrote:
> 
> > can you post a sample file somewhere
> 
> Of course. Here are some you can try out:
> 
> gm_us.wve: (Stereo - 15 FPS) https://0x0.st/X97A.wve
> gm_sp.wve: (Stereo - 15 FPS) https://0x0.st/X97m.wve
> sims.wve: (Mono - 30 FPS) https://0x0.st/X97b.wve
> simsne.wve: (Mono - 30 FPS) https://0x0.st/X97B.wve
> 
> The first two should decode no problem, and are attached for comparison
> purposes.
> 
> Strangely, for all except gm_us.wve, the very last SCDl chunk has a number
> of samples that isn't divisible by 28.
> So you'll get a single decode error at the end for the rest of them, but
> they will still play all the way through and sound good.
> 
> > these whitespace-only changes shouldn't go in the patch.
> > "count2 < ( channels..." looks out of place. drop the space after the
> parenthesis.
> > ditto for these whitespace-only changes above.
> > av_log trailing "\n" missing
> 
> Thank you. I have cleaned those up now.
> 
> > i suggest splitting this into two patches, one for mono adpcm ea, another
> for the frame rate fix.
> 
> Done.

i will apply these.

in future please send patches to the mailing list as separate emails,
e.g. using git-mail, described here:
https://ffmpeg.org//developer.html#toc-Submitting-patches-1

cheers,

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240722/e7b3c616/attachment.sig>