[FFmpeg-devel] [DON'T MERGE PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv

[Martin Storsjö]

On Mon, 3 Jun 2024, Zhao Zhili wrote:

> From: Zhao Zhili <zhilizhao at tencent.com>
>
> ---
> I need help on the test. It succeed with the following patch on ARM64,
> but failed with x86. I'm not sure whether the issue is in the test, or
> hidden in x86 asm, and I don't know x86 asm.

Note that by default, the output of swscale can differ in rounding from 
the reference C code. If the SWS_ACCURATE_RND flag is set, it shouldn't 
differ, though.

So it makes sense to test twice, once with SWS_ACCURATE_RND set, doing a 
bitexact test of the output, and once without it, allowing the values to 
be off by one (or a few?).

See the existing test in checkasm/sw_scale.c for one example on doing 
this.

// Martin