[FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sun Jun 9 12:35:35 EEST 2024


Rémi Denis-Courmont:
> Le sunnuntaina 9. kesäkuuta 2024, 12.26.50 EEST Andreas Rheinhardt a écrit :
>> The two refers to the functions that are set by ff_dct_encode_init():
>> dct_quantize and denoise_dct (the other one). It does not involve
>> dct_unquantize at all.
> 
> I don't think that the patchset implies any involvement of dct_unquantize 
> though. There just so happens to be a contemporary patchset involving H.263 
> DCT unquantize. So I still don't get your point.
> 

You wrote about the "nullity of dct_unquantize" and it not being used at
all. So I inferred that you believe that my "the two" (as in "one of the
two") are dct_quantize and dct_unquantize. Which is not what I meant. I
meant dct_quantize and denoise_dct. So I don't get your latest answer at
all, given that I already stated that I did not refer to dct_unquantize
at all.

- Andreas



More information about the ffmpeg-devel mailing list