[FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

[Lynne]

On 17/06/2024 21:01, Lynne wrote:
> On 17/06/2024 09:35, Anton Khirnov wrote:
>> No tests?
> 
> Tests for this particular part are tricky. We still have the SBR issue 
> where we add a single sample of delay to the output, which the reference 
> samples and their decodings do not. Adding a test would mean modifying 
> the samples in a way where we would not be able to use them after fixing 
> this (in addition to all the other regular AAC samples with SBR we have 
> that would become irrelevant).
> 
> My plan is to fix this after this patch, as its a troublesome topic.

Additionally, we also don't correctly take into account encoder SBR 
delay signalled via MP4.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240617/f4818d9e/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240617/f4818d9e/attachment.sig>