[FFmpeg-devel] [PATCH 1/8 v3] avutil/stereo3d add a Monoscopic view enum value

Vittorio Giovara vittorio.giovara at gmail.com
Sun Jun 23 01:42:25 EEST 2024


On Sat, Jun 22, 2024 at 9:57 PM James Almer <jamrial at gmail.com> wrote:

> On 6/22/2024 12:31 PM, James Almer wrote:
> > We need a way to signal the frame has a single view that doesn't map to
> any
> > particular eye, and it should be the default one.
> >
> > Signed-off-by: James Almer <jamrial at gmail.com>
> > ---
> > Now updating all the fate test...
> >
> > The 3D ones will be updated again in the following commits once ffprobe
> is
> > adapted to properly handle the view field.
>
> Ok, turns out AVStereo3DView is not by Derek from a few days ago but by
> Vittorio from 7 years ago, so of course this change is not ok.
> The new value would need to be added last and moved to the beginning
> after a major bump.
>

I think it's a good idea fwiw, we chatted about it with Derek, but beside
the waiting for the bump, I /believe/ these enum values come straight from
the google metadata document so if they get changed we need to make sure
that these are properly read/written in the related format.
-- 
Vittorio


More information about the ffmpeg-devel mailing list