[FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written

James Almer jamrial at gmail.com
Sun Mar 3 02:31:09 EET 2024


On 3/2/2024 9:27 PM, Michael Niedermayer wrote:
> On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   libavformat/iamfenc.c           | 30 +++++++++++++++++++++++++++++-
>>   tests/ref/fate/iamf-5_1_4       | 14 +++++++-------
>>   tests/ref/fate/iamf-7_1_4       | 16 ++++++++--------
>>   tests/ref/fate/iamf-ambisonic_1 | 10 +++++-----
>>   tests/ref/fate/iamf-stereo      |  4 ++--
>>   5 files changed, 51 insertions(+), 23 deletions(-)
> 
> seems to break fate here
> 
> --- ./tests/ref/fate/iamf-7_1_4	2024-03-03 01:24:48.462539621 +0100
> +++ tests/data/fate/iamf-7_1_4	2024-03-03 01:25:31.762992374 +0100
> @@ -1,12 +1,12 @@
> -5d9fcee2b9b2ad3c802c40bb1147016e *tests/data/fate/iamf-7_1_4.iamf
> +157c3185684e12cc8385ee7c3ef2fb4c *tests/data/fate/iamf-7_1_4.iamf
>   99851 tests/data/fate/iamf-7_1_4.iamf
> -#extradata 0:       34, 0xafa70d5e
> -#extradata 1:       34, 0xafa70d5e
> -#extradata 2:       34, 0xaf7b0d5c
> -#extradata 3:       34, 0xaf7b0d5c
> -#extradata 4:       34, 0xafa70d5e
> -#extradata 5:       34, 0xafa70d5e
> -#extradata 6:       34, 0xafa70d5e
> +#extradata 0:       34, 0x40a802c6
> +#extradata 1:       34, 0x40a802c6
> +#extradata 2:       34, 0x407c02c4
> +#extradata 3:       34, 0x407c02c4
> +#extradata 4:       34, 0x40a802c6
> +#extradata 5:       34, 0x40a802c6
> +#extradata 6:       34, 0x40a802c6
>   #tb 0: 1/44100
>   #media_type 0: audio
>   #codec_id 0: flac

Did you apply the first patch before this one?


More information about the ffmpeg-devel mailing list