[FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

[James Almer]

On 3/5/2024 8:12 PM, Michael Niedermayer wrote:
> On Sun, Mar 03, 2024 at 01:17:57PM +0100, Anton Khirnov wrote:
>> Quoting Anton Khirnov (2024-03-01 17:07:22)
>>> Quoting Michael Niedermayer (2024-02-23 23:50:10)
>>>> Hi Anton
>>>>
>>>> On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote:
>>>>> Will be useful in following commits.
>>>>> ---
>>>>
>>>> breaks:
>>>>
>>>> ./ffmpeg -y -request_channel_layout 3 -i bug/401/mlp_5point1_downmixof6channel.mlp -bitexact file-2-mlp_5point1_downmixof6channel.wav
>>>>
>>>> [mlp @ 0x55690e23ff80] Error setting option request_channel_layout to value 3.
>>>> [mlp @ 0x55690e23ed00] Failed to open codec in avformat_find_stream_info
>>>> [mlp @ 0x55690e23ff80] Error setting option request_channel_layout to value 3.
>>>> Input #0, mlp, from 'bug/401/mlp_5point1_downmixof6channel.mlp':
>>>>    Duration: N/A, start: 0.000000, bitrate: N/A
>>>>    Stream #0:0: Audio: mlp, 48000 Hz, 5.1, s32 (24 bit)
>>>> [mlp @ 0x55690e257900] Error setting option request_channel_layout to value 3.
>>>> [aist#0:0/mlp @ 0x55690e254dc0] [dec:mlp @ 0x55690e256f40] Error while opening decoder: Invalid argument
>>>> [aost#0:0/pcm_s16le @ 0x55690e255a80] Error initializing a simple filtergraph
>>>> Error opening output file file-2-mlp_5point1_downmixof6channel.wav.
>>>> Error opening output files: Invalid argument
>>>>
>>>> i suspect this isnt specific to the file but i can provide it if it
>>>> doesnt reproduce with a other file
>>>
>>> Cannot reproduce with another mlp or 5.1 ac3 file.
>>
>> Cannot reproduce with your sample either. Are you sure you're using the
>> right code? It's branch 'avoption_list' in my tree.
> 
> it worked with "-downmix stereo" instead of "-request_channel_layout 3"
> as suggested by james

Would be nice to find out why. downmix is a codec specific option 
whereas request_channel_layout is a global AVCodecContext option. 
Something here may have affected how child AVOptions are accessed. But 
if Anton can't reproduce it, then maybe your tree was dirty?

> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".