[FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

[asivery]

Great, thank you very much!
I'm attaching the (hopefully) final version of the patch.

MD studio was a piece of software created by a company called "EDL", which in combination with alternative firmware for the Sony MDH-10 MiniDisc recorder (https://www.minidisc.wiki/equipment/sony/misc/mdh-10) let people download raw ATRAC1 audio from their MiniDiscs onto computers, and (probably) put this audio back on their discs later.
Nowadays it's used by software like Web Minidisc Pro (which I maintain) to store ATRAC1 audio, as it (until recently) was the only way to store ATRAC1 so that it would be picked up by VLC. Now we have matroska support for ATRAC1, but I wanted to write a muxer for AEA before I phase it out from new pieces of software, so that the people who would like to use AEA instead of matroska have a way to go back to it.

> On date Saturday 2024-03-09 17:20:49 +0000, ffmpeg-devel Mailing List wrote:
> 
> > Thank you both for the suggestions. I've updated the code as requested, and I apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an oversight on my part.
> > I have also added the stream codec check, and it did get triggered when I tried to feed it audio that was not ATRAC1, so it seems it is required.
> > Regarding titles being truncated - that was my intention. However I've now added a warning if it was going to happen.
> > As for the block count in the header - none of the modern software which uses AEA reads that field, but for the older software, it will now be truncated to UINT32_MAX if needed.
> > Is there anything else that needs changes?
> 
> > From ee1d4c93c66e729d9d0456b2e8e789f3f98389e3 Mon Sep 17 00:00:00 2001
> > From: asivery asivery at protonmail.com
> > Date: Fri, 8 Mar 2024 14:45:02 +0100
> > Subject: [PATCH] avformat/aea: Add aea muxer
> > 
> > Signed-off-by: asivery asivery at protonmail.com
> > ---
> > doc/muxers.texi | 10 +++
> > libavformat/Makefile | 3 +-
> > libavformat/{aea.c => aeadec.c} | 0
> > libavformat/aeaenc.c | 115 ++++++++++++++++++++++++++++++++
> > libavformat/allformats.c | 1 +
> > 5 files changed, 128 insertions(+), 1 deletion(-)
> > rename libavformat/{aea.c => aeadec.c} (100%)
> > create mode 100644 libavformat/aeaenc.c
> > 
> > diff --git a/doc/muxers.texi b/doc/muxers.texi
> > index 2104cc4a95..a4df8f736d 100644
> > --- a/doc/muxers.texi
> > +++ b/doc/muxers.texi
> > @@ -663,6 +663,16 @@ when enabled, write a CRC checksum for each packet to the output,
> > default is @code{false}
> > @end table
> 
> > + at anchor{aea}
> > + at section aea
> 
> 
> nit: sort order (should go after adts)
> 
> > +MD STUDIO audio muxer.
> 
> 
> out of my own curiosity, what is MD STUDIO?
> 
> [...]
> 
> You might also add an entry to the Changelog.
> Looks good to me otherwise, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-aea-Add-aea-muxer.patch
Type: text/x-patch
Size: 7325 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240310/054e6e9b/attachment.bin>