[FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions

[Stefano Sabatini]

On date Sunday 2024-03-10 17:06:18 +0100, Andreas Rheinhardt wrote:
> Stefano Sabatini:
> >> diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h
> >> index e67c59abad..2dd21dea52 100644
> >> --- a/libavcodec/tiff.h
> >> +++ b/libavcodec/tiff.h
> >> @@ -30,9 +30,6 @@
> >>  #ifndef AVCODEC_TIFF_H
> >>  #define AVCODEC_TIFF_H
> >>  
> >> -#include <stdint.h>
> > 
> >> -#include "tiff_common.h"
> > 
> > why? there are cases where only tiff.h must be used?
> > 
> 
> Must? Like in most header matters, this is not a question of "must".

> tiff.h provides (mostly) TIFF related defines that are independent of
> any particular implementation, whereas tiff_common.h mostly provides
> auxiliary functions for decoder/parser (the encoder only uses
> type_sizes*). And not even all of these need it: faxcompr only needs
> tiff.h, not tiff_common.h and mjpegdec.c needs only tiff_common.h.

Makes sense, patch LGTM.