[FFmpeg-devel] [PATCH] lavu/attributes: add ff_ prefix to attribute_deprecated

Anton Khirnov anton at khirnov.net
Tue Mar 12 11:03:43 EET 2024


Quoting Andreas Rheinhardt (2024-03-12 09:56:46)
> Anton Khirnov:
> > Otherwise it might conflict with caller-defined identifiers.
> > 
> > ff because it is not supposed to be used by external callers.
> > ---
> 
> This is public, so it should be av_attribute_deprecated.

As the commit message says, this is not supposed to be used by external
callers. Or do you see any reason why it should be public?

> For the same reason it is actually an API break to no longer provide the
> un-prefixed version.

I am still providing the unprefixed version under a deprecation guard.

> Is this just a general precaution or did you run into an actual conflict?

The former.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list