[FFmpeg-devel] [PATCH v3 3/6] avcodec/ccaption_dec: ignore leading non-breaking spaces
Stefano Sabatini
stefasab at gmail.com
Tue Mar 12 15:50:30 EET 2024
On date Tuesday 2024-03-12 01:00:02 -0500, Marth64 wrote:
> In Closed Captions (US), the non-breaking space (0xA0) can be used to
> align text horizontally from the left when used as a leading character.
> However, CC decoder does not ignore it as a leading character
> like it does an ordinary space, so a blank padding is rendered
> on the black CC box. This is not the intended viewing experience.
>
> Ignore the leading non-breaking spaces, thus creating the intended
> transparency which aligns the text. Since all characters are
> fixed-width in CC, it can be handled the same way as we currently
> treat leading ordinary spaces.
>
> Also, as a nit, lowercase the NBSP's hex code in the entry table to match
> casing of the other hex codes.
>
> Signed-off-by: Marth64 <marth64 at proxyid.net>
> ---
> libavcodec/ccaption_dec.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Still LGTM.
More information about the ffmpeg-devel
mailing list